Remove inactive username_password_not_available test
#1647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is cleanup related to GitoxideLabs#1644, which further complicated the attributes on the `#[ignore]`d `username_password_not_available` test with an empty that was build (but never run) whenever the `expectrl` tests of `gix-prompt` were not built. Instead of keeping its attributes more complicated and maintaining an expectation that they continue to be updated along with the `target_os` support for `expectrl`'s `ptyprocess` dependency, this removes that empty test. The purpose of the test case that this removes is unclear, and it may not have value anymore. It is unclear in part because actual interaction to provide a username and password is likely to work on some systems for which the related tests that use `expectrl` are not being built. But this empty test case might be read to say otherwise. See also the related discussion at: GitoxideLabs#1644 (review)
EliahKagan
force-pushed
the
ptyprocess-targets-next
branch
from
bc0a1ea
to
1fc1471
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is cleanup related to #1644, which further complicated the attributes on the
#[ignore]dusername_password_not_availabletest with an empty that was built (but never run) whenever theexpectrltests ofgix-promptwere not built. Instead of keeping its attributes more complicated and maintaining an expectation that they continue to be updated along with thetarget_ossupport forexpectrl'sptyprocessdependency, this removes that empty test.The purpose of the test case that this removes is unclear, and it may not have value anymore. It is unclear in part because actual interaction to provide a username and password is likely to work on some systems for which the related tests that use
expectrlare not being built. But this empty test case might be read to say otherwise.See also the related discussion at #1644 (review).