-
-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tree-merge follow-up #1651
Merged
tree-merge follow-up #1651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
After all, stopping the merge when there is any conflict is highly relevant.
…f them are considered unresolved.
It's useful to get a reasonable index in any case, even on unborn repositories. It's for cases where the `HEAD` isn't setup at all, despite content being available, and to avoid unnecessary restrictions on what works.
…tor back. This can be useful to have more control over what gets written, or how.
That way, more attached types are used for greater convenience.
By now, `blob-merge` is the lowest-level of features which is required for both tree-merges and commit based merges. Hence it's better to just call it `merge`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finishes up the tree-merge, with various tasks going into it as needed.
Follow-up of #1618.
Tasks
Repository::index_or_load_from_head_or_empty()
- that way it also works in unborn repositories (typically seen in testing). Use it in indiff_resource_cache()
and others that might not want to fail in an unborn repository.gix
merge trees API to take as input and provide output that is fully wrapped. Particularly the tree-editor should be write for simple writes that areanyhow
compatible.an easy way to get the file paths of items that are conflicting (for producing error messages more easily maybe)- not really needed, and there is quickly a lot of paths involved anyway.Next PR
Possible Tasks
Repository::merge_commits()
gix merge commit
libgit2
also doesn't try it.textconv
with context, see this gist for details.GIT_DIR
set, others do.gix-command::Context
.Make blob-merge based conflict handling possible in the tree merge from- not needed for nowgix
at least.Everything is about MergeORT.
ability to re-use object caches of a repo that has seen the base-tree already, but overall, who knows*
-X ours
for instance don't affect tree-related auto-resolutions, just the ones related to content. This could be implemented when there is demand though.merge-ORT
cannot properly handle renames within renamed directories, ending up with the source of the subdir-rename still present.git2::MergeOptions
.