Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make interp_points robust to non-equal grids and impractical default SciPy arguments #484

Merged
merged 26 commits into from
Feb 23, 2024

Conversation

rhugonnet
Copy link
Contributor

@rhugonnet rhugonnet commented Feb 7, 2024

This PR:

  • Makes the behaviour of interp_points consistent between equal and regular grid by using both map_coordinates and interpn from SciPy depending on the grid,
  • Removes the default prefilter argument of map_coordinates that created large data gaps,
  • Corrects the method argument for map_coordinates by mapping it into an order argument,
  • Adds detailed tests with synthetic data to ensure all results are consistent, in addition to the ones existing in test_xy2ij.

Resolves #483

TO-DO:

  • Test the consistency of the AREA_OR_POINT argument between the methods.

@rhugonnet rhugonnet changed the title Fix default kwargs in interp_points Make interp_points robust to non-equal grids and impractical default SciPy arguments Feb 7, 2024
@rhugonnet
Copy link
Contributor Author

Merging this bug fix/improvement as it has pretty serious impact on xDEM, can be reviewed a posteriori.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Several issues with interp_points
1 participant