-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation and warnings before 0.1
release
#502
Conversation
Accounted for all comments, opened issues otherwise. All tests passing. |
@rhugonnet It's probably not deliberate, but the logging.md doc has been removed from your updates, and the logging_configuration.py example has been renamed plot_logging_configuration.py |
@vschaffn This is intended, I tagged you a couple weeks ago to explain these changes: #502 (comment) 😉 |
In short: None of the two pages were rendering after #610. For instance, renaming into "plot_xxx" is required for it to be rendered by Sphinx-Gallery, otherwise it is shown without execution of the code. |
@rhugonnet Sorry, I had forgotten about that comment, thanks for the reminder 😃 |
This PR improves the documentation in preparation for a first minor release
0.1
! 🥳The documentation now separates scientific background content and code examples, adds better links and plots to all feature pages, and adds some auxiliary pages for diverse uses based on user feedback (how to cite, method overview, cheatsheet for helping selecting a method, configuration, ecosystem, etc).
Link to rendered doc: https://xdem-rhugonnet.readthedocs.io/en/towards_0.1/index.html
Detailed documentation changes
This PR:
Other small changes
This PR also has some small changes in the core modules related to the documentation/visualization:
AffineCoreg.to_translations()
andAffineCoreg.to_rotations()
andAffineCoreg.from_rotations()
(asfrom_translations()
already existed) to quickly extract from/build the affine matrix, which might not be easy otherwise for a user (added in a note on the Coregistration page), which directly usepytransform3d
(so don't require testing),resample
option toapply_matrix
for practicality (using a the subfunction_reproject_horizontal_shift_samecrs
that was already tested, and is moved to thebase
module instead ofaffine
),Coreg.info()
for types that were not yet supported (after some testing in the documentation), and aCoregPipeline.info()
that simply wraps theCoreg.info()
of each pipeline step,DEM.estimate_uncertainty()
to have clearer arguments, choice of method mirroring the new documentation.TO-DO:
BlockwiseCoreg
to coregistration page,.meta
keys for users (and make the attribute public in a separate PR),.info()
method forCoregPipeline
,BlockwiseCoreg
,0.1
,dDEM
andDEMCollection
in API, removedDEM
from README, and add warning of potential removal in future,DirectionalBias
correction for sum of sinusoids randomly fails #637Resolves #477 (last step)
Resolves #505
Resolves #464
Resolves #434
Resolves #285
Resolves #275
Resolves #431
Resolves #532
Resolves #528
Resolves #562
Resolves #583
Resolves #614
Opens #637
Opens #638