ChatGPT: Add "NO_RESPONSE" option in case no answer is needed (#2163)

GladysAssistant · Nov 8, 2024 · 37f76c4 · 37f76c4
1 parent c102bbb
commit 37f76c4
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/server/lib/gateway/gateway.forwardMessageToOpenAI.js b/server/lib/gateway/gateway.forwardMessageToOpenAI.js
@@ -11,7 +11,7 @@ const intentTranslation = {
   INFO: 'info.get-info',
 };
 
-const disableOpenAiFirstReply = new Set(['GET_TEMPERATURE', 'GET_HUMIDITY']);
+const disableOpenAiFirstReply = new Set(['GET_TEMPERATURE', 'GET_HUMIDITY', 'NO_RESPONSE']);
 
 /**
  * @public

diff --git a/server/test/lib/gateway/gateway.forwardMessageToOpenAI.test.js b/server/test/lib/gateway/gateway.forwardMessageToOpenAI.test.js
@@ -205,6 +205,18 @@ describe('gateway.forwardMessageToOpenAI', () => {
       intent: 'temperature-sensor.get-in-room',
     });
   });
+  it('should do nothing, no-response was sent', async () => {
+    gateway.gladysGatewayClient.openAIAsk = fake.resolves({
+      type: 'NO_RESPONSE',
+      answer: '',
+      room: '',
+    });
+    const classification = await gateway.forwardMessageToOpenAI({ message, previousQuestions, context });
+    expect(classification).to.deep.equal({
+      intent: undefined,
+    });
+    assert.notCalled(messageManager.reply);
+  });
   it('should start scene from OpenAI', async () => {
     gateway.gladysGatewayClient.openAIAsk = fake.resolves({
       type: 'SCENE_START',