Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rflink with tests #1204

Open
wants to merge 312 commits into
base: master
Choose a base branch
from
Open

Rflink with tests #1204

wants to merge 312 commits into from

Conversation

ngeissel
Copy link
Member

@ngeissel ngeissel commented May 26, 2021

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.json) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!

@relativeci
Copy link

relativeci bot commented Sep 13, 2023

#2891 Bundle Size — 10.54MiB (+1.96%).

734226d(current) vs 8fff0ca master#2883(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 6 changes Regression 2 regressions
                 Current
#2891
     Baseline
#2883
Regression  Initial JS 5.71MiB(+1.62%) 5.62MiB
Regression  Initial CSS 304.91KiB(~+0.01%) 304.89KiB
Change  Cache Invalidation 60.89% 57.81%
No change  Chunks 51 51
Change  Assets 173(+0.58%) 172
Change  Modules 1521(+0.93%) 1507
No change  Duplicate Modules 21 21
Change  Duplicate Code 0.83%(-1.19%) 0.84%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  Change 4 changes Regression 4 regressions
                 Current
#2891
     Baseline
#2883
Regression  JS 7.5MiB (+1.27%) 7.41MiB
Regression  IMG 2.6MiB (+4.35%) 2.49MiB
Regression  CSS 321.69KiB (~+0.01%) 321.68KiB
No change  Fonts 93.55KiB 93.55KiB
Regression  Other 17.78KiB (+0.45%) 17.7KiB
No change  HTML 13.58KiB 13.58KiB

Bundle analysis reportBranch ngeissel:rflinkProject dashboard


Generated by RelativeCIDocumentationReport issue

Copy link

stale bot commented Oct 28, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 28, 2024
@stale stale bot removed the stale label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants