Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle new until date for recurr events #2107

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

bertrandda
Copy link
Contributor

@bertrandda bertrandda commented Jul 30, 2024

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

If recurrent events have no until date on first synchronization, and user add until date, update synchronization do not delete futur events. It's now fixed by deleting all events created by recurr rule that start after until date

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.48%. Comparing base (344ad9b) to head (d71e485).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2107   +/-   ##
=======================================
  Coverage   98.48%   98.48%           
=======================================
  Files         867      867           
  Lines       14172    14182   +10     
=======================================
+ Hits        13957    13967   +10     
  Misses        215      215           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

relativeci bot commented Jul 30, 2024

#2729 Bundle Size — 10.19MiB (0%).

d71e485(current) vs 344ad9b master#2728(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  no changes
                 Current
#2729
     Baseline
#2728
No change  Initial JS 5.5MiB 5.5MiB
No change  Initial CSS 303.12KiB 303.12KiB
No change  Cache Invalidation 0% 0%
No change  Chunks 51 51
No change  Assets 171 171
No change  Modules 1490 1490
No change  Duplicate Modules 21 21
No change  Duplicate Code 0.83% 0.83%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  no changes
                 Current
#2729
     Baseline
#2728
No change  JS 7.28MiB 7.28MiB
No change  IMG 2.48MiB 2.48MiB
No change  CSS 319.91KiB 319.91KiB
No change  Fonts 93.55KiB 93.55KiB
No change  Other 17.62KiB 17.62KiB
No change  HTML 13.58KiB 13.58KiB

Bundle analysis reportBranch bertrandda:fix/caldav-new-untilProject dashboard


Generated by RelativeCIDocumentationReport issue

@bertrandda bertrandda changed the title [WIP] Handle new until date for recurr events Handle new until date for recurr events Aug 22, 2024
@Pierre-Gilles Pierre-Gilles merged commit 48c3786 into GladysAssistant:master Sep 13, 2024
8 of 9 checks passed
@bertrandda bertrandda deleted the fix/caldav-new-until branch September 14, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants