Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate EDF Tempo widget to RTE API #2114

Merged
merged 2 commits into from
Sep 2, 2024
Merged

Conversation

Pierre-Gilles
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles commented Sep 2, 2024

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Fix #2113

Copy link

cloudflare-workers-and-pages bot commented Sep 2, 2024

Deploying gladys-plus with  Cloudflare Pages  Cloudflare Pages

Latest commit: 30504f2
Status: ✅  Deploy successful!
Preview URL: https://9ec8da77.gladys-plus.pages.dev
Branch Preview URL: https://fix-edf-tempo-widget.gladys-plus.pages.dev

View logs

Copy link

relativeci bot commented Sep 2, 2024

#2706 Bundle Size — 10.19MiB (0%).

30504f2(current) vs 303fee7 master#2687(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  no changes
                 Current
#2706
     Baseline
#2687
No change  Initial JS 5.5MiB 5.5MiB
No change  Initial CSS 303.12KiB 303.12KiB
No change  Cache Invalidation 0% 0%
No change  Chunks 51 51
No change  Assets 171 171
No change  Modules 1490 1490
No change  Duplicate Modules 21 21
No change  Duplicate Code 0.83% 0.83%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  no changes
                 Current
#2706
     Baseline
#2687
No change  JS 7.28MiB 7.28MiB
No change  IMG 2.48MiB 2.48MiB
No change  CSS 319.91KiB 319.91KiB
No change  Fonts 93.55KiB 93.55KiB
No change  Other 17.62KiB 17.62KiB
No change  HTML 13.58KiB 13.58KiB

Bundle analysis reportBranch fix-edf-tempo-widgetProject dashboard


Generated by RelativeCIDocumentationReport issue

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.48%. Comparing base (303fee7) to head (30504f2).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2114   +/-   ##
=======================================
  Coverage   98.48%   98.48%           
=======================================
  Files         865      866    +1     
  Lines       14155    14158    +3     
=======================================
+ Hits        13940    13943    +3     
  Misses        215      215           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Pierre-Gilles Pierre-Gilles merged commit 344b601 into master Sep 2, 2024
10 checks passed
@Pierre-Gilles Pierre-Gilles deleted the fix-edf-tempo-widget branch September 2, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate EDF Tempo API to RTE
1 participant