-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zigbee2mqtt: Adding IKEA e1524/e1810 #2120
Zigbee2mqtt: Adding IKEA e1524/e1810 #2120
Conversation
#2875 Bundle Size — 10.29MiB (+0.02%).dbfe104(current) vs 8b1c577 master#2873(baseline) Warning Bundle contains 3 duplicate packages – View duplicate packages Bundle metrics
|
Current #2875 |
Baseline #2873 |
|
---|---|---|
Initial JS | 5.59MiB (+0.03% ) |
5.59MiB |
Initial CSS | 304.73KiB |
304.73KiB |
Cache Invalidation | 54.21% |
0% |
Chunks | 51 |
51 |
Assets | 171 |
171 |
Modules | 1497 |
1497 |
Duplicate Modules | 21 |
21 |
Duplicate Code | 0.84% |
0.84% |
Packages | 124 |
124 |
Duplicate Packages | 3 |
3 |
Bundle size by type 1 change
1 regression
Current #2875 |
Baseline #2873 |
|
---|---|---|
JS | 7.38MiB (+0.02% ) |
7.38MiB |
IMG | 2.48MiB |
2.48MiB |
CSS | 321.52KiB |
321.52KiB |
Fonts | 93.55KiB |
93.55KiB |
Other | 17.62KiB |
17.62KiB |
HTML | 13.58KiB |
13.58KiB |
Bundle analysis report Branch paddyponchero:adding-IKEA-E1524/... Project dashboard
Generated by RelativeCI Documentation Report issue
hey @paddyponchero, any news on this PR ? :) |
I don't have much time as I am renovating a house in evenings and weekends
on top of a full time job.
I was having trouble pushing the changes to github after test, prettier etc.
…On Mon, 30 Sept 2024, 04:12 Pierre-Gilles Leymarie, < ***@***.***> wrote:
hey @paddyponchero <https://github.com/paddyponchero>, any news on this
PR ? :)
—
Reply to this email directly, view it on GitHub
<#2120 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACELGZA2PT2JPKRXIIHATF3ZZC6SBAVCNFSM6AAAAABOLE6ZNKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBRHEYTONRVGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Ok, let me know if you need help finishing this! Good luck on your house :) |
Hey @paddyponchero, the PR is just missing a |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2120 +/- ##
=======================================
Coverage 98.52% 98.52%
=======================================
Files 868 868
Lines 14287 14295 +8
=======================================
+ Hits 14076 14084 +8
Misses 211 211 ☔ View full report in Codecov by Sentry. |
Seems to have pushed correctly this time. Thanks. |
Seems to have pushed properly now,
…On Fri, 8 Nov 2024, 16:20 Pierre-Gilles Leymarie, ***@***.***> wrote:
Hey @paddyponchero <https://github.com/paddyponchero>, the PR is just
missing a npm run prettier in the server folder, I would love to merge
this in Gladys :)
—
Reply to this email directly, view it on GitHub
<#2120 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACELGZGVVCILIJR7DN6INDDZ7TQEDAVCNFSM6AAAAABOLE6ZNKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRVGE4TINZUGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks for this PR 🙏
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm test
on both front/server)npm run eslint
on both front/server)npm run prettier
on both front/server)npm run compare-translations
on front)front/src/config/demo.js
) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!