Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zigbee2mqtt: Adding IKEA e1524/e1810 #2120

Merged

Conversation

paddyponchero
Copy link
Contributor

@paddyponchero paddyponchero commented Sep 17, 2024

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!

Copy link

relativeci bot commented Sep 17, 2024

#2875 Bundle Size — 10.29MiB (+0.02%).

dbfe104(current) vs 8b1c577 master#2873(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#2875
     Baseline
#2873
Regression  Initial JS 5.59MiB(+0.03%) 5.59MiB
No change  Initial CSS 304.73KiB 304.73KiB
Change  Cache Invalidation 54.21% 0%
No change  Chunks 51 51
No change  Assets 171 171
No change  Modules 1497 1497
No change  Duplicate Modules 21 21
No change  Duplicate Code 0.84% 0.84%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2875
     Baseline
#2873
Regression  JS 7.38MiB (+0.02%) 7.38MiB
No change  IMG 2.48MiB 2.48MiB
No change  CSS 321.52KiB 321.52KiB
No change  Fonts 93.55KiB 93.55KiB
No change  Other 17.62KiB 17.62KiB
No change  HTML 13.58KiB 13.58KiB

Bundle analysis reportBranch paddyponchero:adding-IKEA-E1524/...Project dashboard


Generated by RelativeCIDocumentationReport issue

@Pierre-Gilles
Copy link
Contributor

hey @paddyponchero, any news on this PR ? :)

@paddyponchero
Copy link
Contributor Author

paddyponchero commented Oct 1, 2024 via email

@Pierre-Gilles
Copy link
Contributor

Ok, let me know if you need help finishing this! Good luck on your house :)

@Pierre-Gilles Pierre-Gilles changed the title Adding ikea e1524/e1810 WIP : Adding ikea e1524/e1810 Oct 4, 2024
@Pierre-Gilles
Copy link
Contributor

Hey @paddyponchero, the PR is just missing a npm run prettier in the server folder, I would love to merge this in Gladys :)

Copy link

codecov bot commented Nov 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.52%. Comparing base (8b1c577) to head (dbfe104).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2120   +/-   ##
=======================================
  Coverage   98.52%   98.52%           
=======================================
  Files         868      868           
  Lines       14287    14295    +8     
=======================================
+ Hits        14076    14084    +8     
  Misses        211      211           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paddyponchero
Copy link
Contributor Author

Hey @paddyponchero, the PR is just missing a npm run prettier in the server folder, I would love to merge this in Gladys :)

Seems to have pushed correctly this time. Thanks.

@paddyponchero
Copy link
Contributor Author

paddyponchero commented Nov 9, 2024 via email

@Pierre-Gilles Pierre-Gilles changed the title WIP : Adding ikea e1524/e1810 Zigbee2mqtt: Adding IKEA e1524/e1810 Nov 11, 2024
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for this PR 🙏

@Pierre-Gilles Pierre-Gilles merged commit 5b57c1d into GladysAssistant:master Nov 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants