Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): add aarch64 release target #2221

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Conversation

tychoish
Copy link
Collaborator

@tychoish tychoish commented Dec 7, 2023

Closes: #2182

The justfile already has support.

I'd definitely like someone with a bit more rust toolchain familiarty
to gut check my assumption that this will just work on such an old
version of ubuntu.

Copy link
Member

@scsmithr scsmithr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it compiles, I'm sure it'll work. Old version of ubuntu is because of glibc: #1739

@scsmithr
Copy link
Member

scsmithr commented Dec 7, 2023

Running release build here: https://github.com/GlareDB/glaredb/actions/runs/7133666350

@@ -18,7 +18,7 @@ jobs:
target: x86_64-pc-windows-msvc
- os: ubuntu-2004-8-cores
target: x86_64-unknown-linux-gnu
- os: ubuntu-2004-8-cores
- os: ubuntu-2204-8-cores
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need to create a machine type for this. The existing 8 core ones are custom large runners.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how do we do that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-01-05 at 1 03 19 PM

runner added

@tychoish
Copy link
Collaborator Author

Just to follow up, I think @scsmithr needs to add the updated builder to the GlareDB org to unblock this.

@tychoish
Copy link
Collaborator Author

tychoish commented Jan 8, 2024

@tychoish
Copy link
Collaborator Author

I've poked at this and my current assessment is that: there's some binary blob (or something) and/or it's falling back to using the wrong linker.

I can reproduce this locally but I haven't convinced cargo/rustc to do the right thing.

@universalmind303
Copy link
Contributor

marking this as draft as I don't think this is actively waiting on review

@universalmind303 universalmind303 marked this pull request as draft March 5, 2024 14:38
@tychoish tychoish marked this pull request as ready for review July 17, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please distribute aarch64-unknown-linux-gnu binaries
4 participants