-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(build): add aarch64 release target #2221
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it compiles, I'm sure it'll work. Old version of ubuntu is because of glibc: #1739
Running release build here: https://github.com/GlareDB/glaredb/actions/runs/7133666350 |
@@ -18,7 +18,7 @@ jobs: | |||
target: x86_64-pc-windows-msvc | |||
- os: ubuntu-2004-8-cores | |||
target: x86_64-unknown-linux-gnu | |||
- os: ubuntu-2004-8-cores | |||
- os: ubuntu-2204-8-cores |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might need to create a machine type for this. The existing 8 core ones are custom large runners.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how do we do that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to follow up, I think @scsmithr needs to add the updated builder to the GlareDB org to unblock this. |
Seems to be hitting a link error: https://github.com/GlareDB/glaredb/actions/runs/7438394256/job/20237097364#step:6:1315 |
I've poked at this and my current assessment is that: there's some binary blob (or something) and/or it's falling back to using the wrong linker. I can reproduce this locally but I haven't convinced cargo/rustc to do the right thing. |
marking this as draft as I don't think this is actively waiting on review |
Closes: #2182
The
justfile
already has support.I'd definitely like someone with a bit more rust toolchain familiarty
to gut check my assumption that this will just work on such an old
version of ubuntu.