Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: excel table support for excel data sources #3118

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tychoish
Copy link
Collaborator

Closes #2949

@talagluck can you write the tests for this (e.g. need a worksheet
with a table and corresponding tests.)

@talagluck
Copy link
Contributor

I added a worksheet and tests, but I can't get the tests to pass locally. I get

Error while running test `sqllogictests/xlsx` error=test fail: query failed: internal error: cannot execute simple query: db error: ERROR: External error: External error: Table 'users' not found

I tried with a few different tables, but they are all not found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Excel Tables
2 participants