Allow for handlebars 2.0 #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree with this. please pull. |
|
Any chance we can get this merged? I maintain a huge Ember app and this is our only blocker to upgrading to Ember 1.9. I'd prefer not to fork over something so small. |
|
Published to v0.1.5: https://github.com/Glavin001/ember-c3/releases/tag/v0.1.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed the handlebars dependency since ember already handles it, so that I can upgrade to ember 1.9 and handlebars 2.0. I also upgraded grunt-ember-templates and the related libraries so the site still builds with the new version of handlebars.
I'm still learning ember, so I'm not sure if there was a reason that the handlebars dependency was specified. If there was, could we change how the dependency is specified so we can still upgrade ember and handlebars?
Thanks.