Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to Ember CLI plugin #16

Merged
merged 15 commits into from
Sep 5, 2015
Merged

Convert to Ember CLI plugin #16

merged 15 commits into from
Sep 5, 2015

Conversation

Robdel12
Copy link
Contributor

This is still a work in progress I think it's good!

  • TODO: Successfully npm link in a project and test the generator
  • TODO: Clean up code a little
  • TODO: Update package json
  • TODO: Get JSON editor to work
  • TODO: Build so gh pages will work still.
  • TODO: Add GH-Pages builder to project: https://github.com/poetic/ember-cli-github-pages
  • TODO: Update to use ember-jsoneditor CLI addon (@Glavin001 it doesn't look like it's published as an ember addon?)

This takes care of #14

Notes

@Glavin001 I had to edit ember-jsoneditor for it to work.

Here I had to change the code to:

var editor = new JSONEditor(container, options, json);

}.observes('data').on('didInsertElement')
});

// Ember.Handlebars.helper('c3-chart', Ember.C3.ChartComponent);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • TODO: Remove dead code

@Robdel12 Robdel12 changed the title WIP: Convert to Ember CLI plugin Convert to Ember CLI plugin Jan 25, 2015
@Glavin001 Glavin001 self-assigned this Feb 1, 2015
@Glavin001
Copy link
Owner

Thanks for submitting! Is ember-cli-github-pages still a TODO?

@Robdel12
Copy link
Contributor Author

Robdel12 commented Feb 2, 2015

Ah yes! That way the example on the gh-pages branch will be up to date. I can do this after the Super Bowl tonight.

@MiguelMadero
Copy link

It would be nice to ckage the c3 lib as pure json for those non-embercli consumers.

@Robdel12
Copy link
Contributor Author

Robdel12 commented Feb 2, 2015

@MiguelMadero would keeping the current state of the project on a separate branch work?

@MiguelMadero
Copy link

@Robdel12 I guess that's a simple option, but then those would be two different versions to keep in sync/publish. For one of our internal libraries, we started shipping a pre-built lib that doesn't depend on EmberCLI. It's not too hard, and more ember-c3 it should be straightforward.

Packaging Ember CLI Add-ons

@Robdel12
Copy link
Contributor Author

@Glavin001 did we want to revisit/revive this?

@Glavin001
Copy link
Owner

Oh yeah, @Robdel12. If I recall when I last tried this pull request I was unable to get the gh-pages demo to work. I am not currently using ember-c3 with any of my current projects so I do not have any personal uses to test it further and it's hard to find time to contribute back to this particular project.
A simply demo in the gh-pages branch would be sufficient to make sure this works and does not break anything. Essentially take gh-pages and make it using the Ember-CLI rewrite you developed.
This weeks I'm going to be working on other things but I should be able to check if this PR is in working order at the end of the week and we can get this all merged up. Thanks!

@Robdel12
Copy link
Contributor Author

So I updated it to the latest ember and had to remove the JSONEditor since that's now borked too. And there's a bash script used to deploy to Gh-pages.. Which I don't like but It.. works. Meh.

http://robdel12.github.io/ember-c3/

I'll keep dorkin with it.

@Glavin001
Copy link
Owner

Great work!!

What was the problem with JSONEditor again?

I'll keep dorkin with it.

Let me know once you are happy with your PR. I will be busy until at least Sunday this week, so I may get a chance to check it over then if you're satisfied with your work / implementation by then.

Keep up the great work!

@wvteijlingen
Copy link

👍 It looks like this removes the deprecated use of Ember.Handlebars.helper. Can this be merged into a release, maybe just with the JSON editor removed from the demo page?

@Glavin001
Copy link
Owner

I now have a new project that uses both Ember-CLI and C3, and so I will be revisiting this package soon -- hopefully this upcoming week. I will also clean up JSON editor and make this all work as expected, removing deprecated APIs, etc.

Thank you everyone for your patience!

@Glavin001 Glavin001 added this to the v0.1.0 milestone Aug 12, 2015
@Glavin001
Copy link
Owner

I have completed ember-jsoneditor. Now that I know how to convert to a Ember-CLI and the ember-jsoneditor component is ready, I can finish this work off with ember-c3.

@Glavin001 Glavin001 merged commit 1270142 into Glavin001:master Sep 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants