-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert to Ember CLI plugin #16
Conversation
}.observes('data').on('didInsertElement') | ||
}); | ||
|
||
// Ember.Handlebars.helper('c3-chart', Ember.C3.ChartComponent); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- TODO: Remove dead code
Thanks for submitting! Is ember-cli-github-pages still a TODO? |
Ah yes! That way the example on the gh-pages branch will be up to date. I can do this after the Super Bowl tonight. |
It would be nice to ckage the c3 lib as pure json for those non-embercli consumers. |
@MiguelMadero would keeping the current state of the project on a separate branch work? |
@Robdel12 I guess that's a simple option, but then those would be two different versions to keep in sync/publish. For one of our internal libraries, we started shipping a pre-built lib that doesn't depend on EmberCLI. It's not too hard, and more ember-c3 it should be straightforward. |
@Glavin001 did we want to revisit/revive this? |
Oh yeah, @Robdel12. If I recall when I last tried this pull request I was unable to get the gh-pages demo to work. I am not currently using ember-c3 with any of my current projects so I do not have any personal uses to test it further and it's hard to find time to contribute back to this particular project. |
So I updated it to the latest ember and had to remove the JSONEditor since that's now borked too. And there's a bash script used to deploy to Gh-pages.. Which I don't like but It.. works. Meh. http://robdel12.github.io/ember-c3/ I'll keep dorkin with it. |
Great work!! What was the problem with JSONEditor again?
Let me know once you are happy with your PR. I will be busy until at least Sunday this week, so I may get a chance to check it over then if you're satisfied with your work / implementation by then. Keep up the great work! |
👍 It looks like this removes the deprecated use of |
I now have a new project that uses both Ember-CLI and C3, and so I will be revisiting this package soon -- hopefully this upcoming week. I will also clean up JSON editor and make this all work as expected, removing deprecated APIs, etc. Thank you everyone for your patience! |
I have completed |
This is still a work in progressI think it's good!npm link
in a project and test the generatorThis takes care of #14
Notes
@Glavin001 I had to edit ember-jsoneditor for it to work.
Here I had to change the code to: