Fix jumps issue at the end of pan gesture #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Glazzes
commented
Mar 28, 2024
Glazzes
commented
- Fixes jump issue at the end of pan gesture, by disabling pan gesture at the beginning of pinch gesture, this prevent both gestures from colliding with each other.
- Makes panWithPinch feature opt in for iOS users because of this React Native Gesture Handler's issue, this one will be enabled by default again as soon as the next release of Gesture Handlers containing this fix comes out.
Disable pan gesture at the beginning of pinch gesture instead of the end this change has been applied to both ResumableZoom and CropZoom refs #10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.