Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve GUI of NuGet for Unity window #617

Merged
merged 39 commits into from
Feb 9, 2024
Merged

Conversation

AnnulusGames
Copy link
Contributor

@AnnulusGames AnnulusGames commented Jan 21, 2024

NuGet for Unity is a great tool, but its GUI looks a little outdated and feels clunky. This pull request will refresh the look of the editor window and bring it in line with the modern Unity editor.

Before/After

Online

img1-before img1-after

Installed

img2-before img2-after

Updates

img3-before img3-after

If you directly change the properties of the EditorStyles class, it will affect the entire editor. Therefore, I made a copy and changed it to use that one.
@AnnulusGames AnnulusGames changed the title Improved GUI of NuGet for Unity window Improve GUI of NuGet for Unity window Jan 21, 2024
Copy link
Collaborator

@JoC0de JoC0de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AnnulusGames Thank you for the pull request! Your contribution is greatly appreciated and enhances the project. Looks really Nice!
I run autoformatter on the changes and added the missing documentation, so from my side we can merge it. Is it still work in progress or can we merge it?
It would be nice if we / you update the images in the documentation to show the new UI.

@AnnulusGames
Copy link
Contributor Author

I've updated the images in the documentation. The work has already been completed, so there is no problem in merging it.

src/NuGetForUnity/Editor/Ui/NugetWindow.cs Outdated Show resolved Hide resolved
src/NuGetForUnity/Editor/Ui/NugetWindow.cs Show resolved Hide resolved
src/NuGetForUnity/Editor/Ui/NugetWindow.cs Outdated Show resolved Hide resolved
src/NuGetForUnity/Editor/Ui/NugetWindow.cs Outdated Show resolved Hide resolved
src/NuGetForUnity/Editor/Ui/NugetWindow.cs Outdated Show resolved Hide resolved
src/NuGetForUnity/Editor/Ui/NugetWindow.cs Outdated Show resolved Hide resolved
src/NuGetForUnity/Editor/Ui/NugetWindow.cs Outdated Show resolved Hide resolved
@AnnulusGames
Copy link
Contributor Author

I think the best way is to replace the drawing process from IMGUI to UIToolkit, but it would be difficult to migrate this huge amount of code to it, so I improved the appearance by rewriting the existing code. I think this is enough for now.

@JoC0de JoC0de merged commit a8ef661 into GlitchEnzo:master Feb 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants