Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Reminders #296

Merged
merged 11 commits into from
Sep 20, 2016
Merged

Add Reminders #296

merged 11 commits into from
Sep 20, 2016

Conversation

paolorotolo
Copy link
Collaborator

Please review and merge.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.7%) to 12.832% when pulling 7556aa9 on reminders into 5114f8a on develop.


public void showDuplicateError() {
View parentLayout = findViewById(R.id.activity_reminders_root_view);
Snackbar.make(parentLayout, "This reminder already exists.", Snackbar.LENGTH_SHORT).show();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Localisation?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woops

@emartynov
Copy link
Contributor

Check also some codacy warnings

@paolorotolo
Copy link
Collaborator Author

yeah some variables are not used because I've half coded the support for Nougat notifications.
I need another feature to land before introducing this.

@emartynov
Copy link
Contributor

I will test today and merge if no issues found!

@emartynov emartynov self-assigned this Sep 12, 2016
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.7%) to 12.854% when pulling b5eb81d on reminders into 5114f8a on develop.

@paolorotolo
Copy link
Collaborator Author

@emartynov We're ready to merge now.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.7%) to 12.829% when pulling 6c1895b on reminders into 5114f8a on develop.

@emartynov emartynov merged commit acacf1d into develop Sep 20, 2016
@emartynov emartynov deleted the reminders branch September 20, 2016 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants