Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solving the CSV Export problem on Samsung S6 #324

Merged

Conversation

Ghazghkull
Copy link
Contributor

@Ghazghkull Ghazghkull commented Oct 29, 2016

The main problem seems to be related witth the static method exporting the CSV.

Creating the needed class every time into the new thread solves the problem

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 15.055% when pulling 648592b on Ghazghkull:export_csv_error_for_samsung_s6 into f36f890 on Glucosio:develop.

@satya164
Copy link
Collaborator

Why does the error happen with a static method?

@Ghazghkull
Copy link
Contributor Author

Ghazghkull commented Oct 30, 2016

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 15.341% when pulling 2c060a8 on Ghazghkull:export_csv_error_for_samsung_s6 into f36f890 on Glucosio:develop.

@paolorotolo
Copy link
Collaborator

So I talked with @bkerensa. Even if we fully don't understand why the error occurs, a fix is better than nothing. @Ghazghkull I see a conflict (sorry :P), can you please solve it? I will merge after.

@Ghazghkull
Copy link
Contributor Author

This night when I can access to my personal computer, I will solve the conflict :)

@paolorotolo
Copy link
Collaborator

I solved some problems with dependencies. Now you should be able to compile without issues :)

@Ghazghkull
Copy link
Contributor Author

Thanks, last night I had a lot of errors and I din't know why....

@paolorotolo paolorotolo merged commit 313e0b6 into Glucosio:develop Jan 4, 2017
@paolorotolo
Copy link
Collaborator

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants