v5.5.2 #3
Merged
v5.5.2 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…veAndUpdateDevMethods commit 0d0d74b.
Adds CpM, Candy and Candy XL values for levels 40.5 to 50. Still needs an update to actually scan Candy XL and Mega Energy.
It also redoes how it determines the costs. Instead of doing the candy costs again somewhere else, reuse the array from the Data class. It also stores all costs into the UpgradeCost class.
Sometimes it reads wrong values (especially 0, 0, 0) and in those cases it might be handy to manually restart appraisal scanning.
…of stray `= false;`
It downloads a CSV from Google Sheets with the names and translations of them and creating the corresponding XML files.
Zygarde has a uniqueId of "YVELTAL" for some reason, putIfAbsent
prevents overwriting (Although only if Yveltal shows up first, which
is the case in the current GM, and the best generic fix I can think
of for now)
Had to update Meltan and Melmetal offsets
A trainer with a level below 40 cannot power up a pokemon with a level above 40. So the maximum pokemon level has two maximum values.
When switching from Appraisal to Input, it would loose the selected Pokemon and select the originally selected one. It now uses the stored Pokemon when opening the Input fraction.
When changing the Pokemon name in the text field it wasn't actually updating the prediction accordingly. It also removed duplicated code and does show the same button text when the scan failed.
old implementation of fixOcrLettersToNums could cause logic to think it found a good value when reading garbage, which would break scanning. New version is more robust (but likely not perfect)
default "" input handled differently, will never return null
jw.change_output_dir
Revert "jw.change_output_dir"
This solves the timing issue with creating ScreenGrabber
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately PokeSpam had to be disabled and PokeBattler is still horribly out of date. Recalibration is also extremely finicky right now, hoping to fix that in v5.5.3