Added some logging of X224 negotiation failures #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Res260
reviewed
Apr 28, 2019
|
Press F to pay respects to the forgotten PR 🙏 |
obilodeau
changed the title
|
After an in-person review refresh with Emilio, I made all the requested changes. Please consider for merge again. May I suggest using a squash merge 😉 |
|
Will test then merge if nothing is on fire! |
|
Tested the changes, and added code to transfer the FailurePDU back to the client so the client can gracefully exit with a message saying that NLA is not supported on its computer (lol). Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP because I left a TODO task in there and forgot why.
Please review and enlighten me.