-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pyrdp-player improvements #119
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After using the player for a few more days, I fixed some things that were getting annoying.
The current options doesn't persist on close. |
Pourliver
changed the title
Added signals to modify pyrdp-player tab name at runtime
Pyrdp-player improvements
Jun 17, 2019
Res260
reviewed
Jun 17, 2019
Res260
approved these changes
Jun 20, 2019
xshill
requested changes
Jun 25, 2019
xshill
approved these changes
Jul 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After using the live pyrdp-player for a few days, with multiple inbound connections at the same time, I had a few improvement ideas :
The onDisconnection hook wasn't used correctly, so I've removed it, and I added a new rename hook. I rename a tab whenever we receive the clientDataPDU, and on client disconnection. I don't really like using Signals() for that, but it seems common in Qt. Let me know what you think.