Added recursive download and tab icon when a filesystem is shared #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Res260
reviewed
Jul 31, 2019
|
TODO: Add the pr changes to changelog.md |
|
Merged master into the branch, updated changelog and tested. Ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can now right click and download a folder recursively. I made the downloadDialog non-modal, since a modal is a blocking action, meaning that we cannot focus the original window. I did the same thing to the download completion popup.
I also added a jobs queue that allows us to queue up downloads, they starts as soon as the previous download has ended. Practical when we are downloading a huge zip / folder, and we want to keep looking for interesting file.
The logic may be confusing, because of the nature of the observers, I had to make sure that only one job was executing at a time.
The 3 queues have distinct jobs.
jobsQueueholds the action requested by the user. When a job is being processed, the sub-jobs goes intodirectoryDownloadQueueandfileDownloadQueue. When we download a folder, we start by downloading all files inside the folder, then we do the same for each sub-folder.I've worked on this for a while so I don't know what I should explain design wise lol. Let me know if anything is unclear.