Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: UTF-8 support for docker images. #249

Merged
merged 3 commits into from
Oct 16, 2020
Merged

fix: UTF-8 support for docker images. #249

merged 3 commits into from
Oct 16, 2020

Conversation

alxbl
Copy link
Collaborator

@alxbl alxbl commented Oct 2, 2020

Closes #247.

Copy link
Collaborator

@obilodeau obilodeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in the Dockerfile seems to be only made to the compile image. Did you test this? If it fixed the problem it feels like the logger changes were enough.

That said, it might fail at the filesystem file open moment...

I think we should add the locale/utf-8 changes to the runtime image too.

@alxbl
Copy link
Collaborator Author

alxbl commented Oct 16, 2020

Hmm, I just tested again, now I get utf-8... for both images (slim and not slim) I'm not sure why that is. I'll try to play around with the dockerfiles and see if we can just get rid of the extra steps.

@obilodeau
Copy link
Collaborator

Have in mind that I bumped the docker images to ubuntu 20.04 recently in #251. Maybe there's a ubuntu fix or a python version change that fixed the behavior there.

@alxbl
Copy link
Collaborator Author

alxbl commented Oct 16, 2020

Ah, that could be it. The LANG and LC_TYPE are still not set though.

In any case, I tried removing the Dockerfile changes and the issue still seems resolved. We'll keep the logging part in, but I believe that updating to 20.04 means Python 3.8, which uses utf8 by default.

Copy link
Collaborator

@obilodeau obilodeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging

@obilodeau obilodeau merged commit 93ca836 into master Oct 16, 2020
@obilodeau obilodeau deleted the fix-247 branch August 6, 2021 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crawler - Non-ASCII filenames cause exception to be thrown
2 participants