Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create parents when creating symlink's directory #299

Merged
merged 3 commits into from
Mar 11, 2021

Conversation

xshill
Copy link
Collaborator

@xshill xshill commented Mar 3, 2021

This fixes a bug causing the connection to crash when trying to save a file whose grand-parent directory hasn't been created yet.

@obilodeau
Copy link
Member

Is it safe to assume that the whole connection wasn't crashing but the individual IO channels were?

@xshill
Copy link
Collaborator Author

xshill commented Mar 4, 2021

Is it safe to assume that the whole connection wasn't crashing but the individual IO channels were?

For me it made the whole connection crash on Windows.

Copy link
Member

@obilodeau obilodeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@obilodeau obilodeau merged commit ca8ee72 into master Mar 11, 2021
@obilodeau obilodeau deleted the fix-filemapping-parents branch August 6, 2021 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants