Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Massive MP4 conversion speed improvement #349

Merged
merged 9 commits into from
Aug 30, 2021
Merged

Massive MP4 conversion speed improvement #349

merged 9 commits into from
Aug 30, 2021

Commits on Aug 27, 2021

  1. Using nparray instead of PIL to pass QImage to PyAV 

    Benchmarks are impressive with around 6x-7x encoding speed reduction
    @obilodeau
    obilodeau committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    9d97c55 View commit details
    Browse the repository at this point in the history

  2. Added TODO task for other encoding speed opportunities

    @obilodeau
    obilodeau committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    4d2a4b3 View commit details
    Browse the repository at this point in the history

  3. Updated CHANGELOG

    @obilodeau
    obilodeau committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    270d760 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2021

  1. Removing the pillow/PIL dependency and dead code 

    We no longer require pillow since we convert images to numpy arrays when encoding video now.
    @obilodeau
    obilodeau committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    16e1563 View commit details
    Browse the repository at this point in the history

  2. import cleanup

    @obilodeau
    obilodeau committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    51e40b0 View commit details
    Browse the repository at this point in the history

  3. Added conversion integration tests

    @obilodeau
    obilodeau committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    4a45e48 View commit details
    Browse the repository at this point in the history

  4. Added a new convert test 

    I couldn't use the current session test since it doesn't carry the
capabilities packet and I couldn't paint the correct first frame and we
don't support live resize for the video conversion yet.
    @obilodeau
    obilodeau committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    05312d6 View commit details
    Browse the repository at this point in the history

  5. Removed a type warning

    @obilodeau
    obilodeau committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    8032ce4 View commit details
    Browse the repository at this point in the history

  6. Updated CHANGELOG

    @obilodeau
    obilodeau committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    f85f1de View commit details
    Browse the repository at this point in the history