Dropping support of pre-built docker images for linux/arm/v7 #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cryptography requires rustc and cargo in order to build since the beginning of last year. We carried a workaround when we implemented ARM builds for docker in 724bd5e.
When I pushed the dependency updates, our ARMv7 (aka armhf) docker builds stopped working: https://github.com/GoSecure/pyrdp/runs/4861875591?check_suite_focus=true.
After investigation, the cryptography project seemed to have stepped up and is providing prebuilt cryptography packages for a lot of platforms but not linux/arm/v7 and they have no intention of doing so: pyca/cryptography#6286.
I spent one hour trying to build the package inside the compile container with rust and cargo installed but it would fail for various reasons including obscure linux or QEMU ones. Thinking about how many linux/arm/v7 users we might have out there I don't think it's worth the effort.
If someone reads this, know that you can always install pyrdp from source and it should work since the issues were around cargo having problems with the docker+QEMU emulation.
We still build docker images for ARM64 (aka aarch64).