Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update EndeavourOS logo #59

Merged
merged 1 commit into from
Jul 25, 2024
Merged

update EndeavourOS logo #59

merged 1 commit into from
Jul 25, 2024

Conversation

Un1q32
Copy link
Contributor

@Un1q32 Un1q32 commented Jul 23, 2024

top is before, bottom is after

image

real logo:
image

Copy link
Owner

@Gobidev Gobidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that changing the middle part to purple better resembles the actual logo, the other changes might be worth experimenting with a bit more.

You could also try using 256-color, as this is supported in pfetch-rs to better match the original colors, you can take a look at the Rocky Linux logo as an example.

pfetch-extractor/logos.sh Show resolved Hide resolved
pfetch-extractor/logos.sh Show resolved Hide resolved
@Un1q32
Copy link
Contributor Author

Un1q32 commented Jul 25, 2024

I don't want to use 256 color mode, since not all terminals support it, and I want to use the same logo for this and https://github.com/Un1q32/pfetch. I can't support 256 color modes there since I aim for maximum portability and simplicity.

@Gobidev Gobidev merged commit 7a22f30 into Gobidev:main Jul 25, 2024
5 of 6 checks passed
@Gobidev
Copy link
Owner

Gobidev commented Jul 25, 2024

I don't want to use 256 color mode, since not all terminals support it, and I want to use the same logo for this and https://github.com/Un1q32/pfetch. I can't support 256 color modes there since I aim for maximum portability and simplicity.

If 256 color is not available, it should choose the nearest supported color, but I see your point. Thank you for the contribution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants