Bug with sim_time

[mathomp4]

As discovered by @tclune and myself when trying to use the "sim_time" functionality of pflogger, this code:

pFlogger/src/Formatter.F90

Lines 271 to 280 in 6011e59

	if(this%fmt_uses_simTime) then
	if (allocated(this%datefmt)) then
	call get_sim_time(dict)
	simtime = FormatString(this%datefmt, dict)
	else
	simtime = FormatString(DEFAULT_DATE_FMT, dict)
	end if
	call extra%insert('simtime', String(simtime))
	end if

is wrong because if you don't specify a datefmt it will crash because call get_sim_time(dict) is never called.

The possible solution is to move the call above the if-block:

      if(this%fmt_uses_simTime) then
         call get_sim_time(dict)
         if (allocated(this%datefmt)) then
            simtime = FormatString(this%datefmt, dict)
         else
            simtime = FormatString(DEFAULT_DATE_FMT, dict)
         end if
         
         call extra%insert('simtime', String(simtime))
      end if