Disable two lint rules which are being removed. #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each of these are going to be removed soon. * avoid_null_checks_in_equality_operators * unsafe_html Work towards https://github.com/dart-lang/linter/issues/5063 and https://github.com/dart-lang/linter/issues/5001
15 tasks
|
@Goddchen please review. This PR is blocking the removal of these lint rules in the Dart SDK, as dart-rfb is in Flutter's customer test registry. |
8 tasks
auto-submit bot
pushed a commit
to flutter/tests
that referenced
this pull request
Nov 7, 2024
Work towards https://github.com/dart-lang/linter/issues/5063 and https://github.com/dart-lang/linter/issues/5001 There are open PRs for blocked Dart SDK work in these two repos: * Goddchen/dart-rfb#26 * Goddchen/flutter-rfb#24 @Goddchen has not responded to these in 72 hours. This change disables the tests. The tests can be re-enabled when those PRs have been merged, and the subsequent relevant commits in this repo bumped.
Goddchen
approved these changes
Nov 13, 2024
|
Thank you for creating this PR! |
8 tasks
auto-submit bot
pushed a commit
to flutter/tests
that referenced
this pull request
Nov 19, 2024
since the deprecated lint rules have been removed See these 2 PRs: Goddchen/dart-rfb#26 and Goddchen/dart-rfb#25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each of these are going to be removed soon.
Work towards dart-lang/sdk#59514 and dart-lang/sdk#57099