Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce manifest.json debug log length #101

Merged

Conversation

ithinkandicode
Copy link
Collaborator

Logging the full manifest.json for every mod floods the logs, and always means the Godot console says "show less text".

This minor tweak changes it to log the contents as a single line instead.

There's also a const option (USE_EXTENDED_DEBUGLOG) to log the full contents, as it may still be helpful during development.

@ithinkandicode ithinkandicode changed the base branch from main to develop February 8, 2023 09:59
Copy link
Collaborator

@Qubus0 Qubus0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea, that was necessary 👍

@ithinkandicode ithinkandicode merged commit d545ac0 into GodotModding:develop Feb 8, 2023
@ithinkandicode ithinkandicode deleted the reduce-json-log-length branch February 8, 2023 13:42
@ithinkandicode
Copy link
Collaborator Author

I'm providing support to a newbie modder and seeing the full JSON is actually quite helpful.

Perhaps we should enable the USE_EXTENDED_DEBUGLOG option by default

@ithinkandicode ithinkandicode mentioned this pull request Feb 22, 2023
@KANAjetzt KANAjetzt mentioned this pull request Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants