Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✔ Load before #115

Closed
wants to merge 6 commits into from
Closed

✔ Load before #115

wants to merge 6 commits into from

Conversation

KANAjetzt
Copy link
Member

Load before some mod

Adds functionality to specify a mod you want to load before your own mod.

Load before field added to manifest.json in extra -> godot -> load_before

For example:
"load_before": ["Darkly77-ContentLoader"],

{
	"name": "WhatAmILookingAt",
	"namespace": "KANA",
	"version_number": "1.0.0",
	"description": "Tells you where this thing is from.",
	"website_url": "https://github.com/BrotatoMods",
	"dependencies": [],
	"extra": {
		"godot": {
			"incompatibilities": [],
			"load_before": ["Darkly77-ContentLoader"],
			"authors": ["KANA"],
			"compatible_mod_loader_version": "4.3.0",
			"compatible_game_version": ["0.8.0.3"],
			"config_defaults": {}
		}
	}
}

Will need some more testing, this is just a naive implementation.


closes #114

@KANAjetzt KANAjetzt added the enhancement New feature or request label Feb 15, 2023
@KANAjetzt KANAjetzt added this to the v4.3.0 milestone Feb 15, 2023
@KANAjetzt KANAjetzt requested review from ithinkandicode, Qubus0 and a team February 15, 2023 09:22
@KANAjetzt
Copy link
Member Author

DEBUG ModLoader: Checking dependencies - mod_id: KANA-OverwritesTest dependencies: []
DEBUG ModLoader: Checking dependencies - mod_id: KANA-TestMod0 dependencies: []
DEBUG ModLoader: Checking dependencies - mod_id: KANA-TestMod1 dependencies: []
DEBUG ModLoader: Checking dependencies - mod_id: KANA-TestMod2 dependencies: []
DEBUG ModLoader: Load before detected -> Set importance for KANA-OverwritesTest to 1, it will load before [KANA-TestMod1]
DEBUG ModLoader: Load before detected -> Set importance for KANA-TestMod0 to 1, it will load before [KANA-TestMod2]
DEBUG ModLoader: Load before detected -> Set importance for KANA-TestMod2 to 2, it will load before [KANA-OverwritesTest]
INFO ModLoader: mod_load_order -> 1) KANA-TestMod2
INFO ModLoader: mod_load_order -> 2) KANA-OverwritesTest
INFO ModLoader: mod_load_order -> 3) KANA-TestMod0
INFO ModLoader: mod_load_order -> 4) KANA-TestMod1

@KANAjetzt KANAjetzt deleted the branch GodotModding:develop February 16, 2023 13:28
@KANAjetzt KANAjetzt closed this Feb 16, 2023
KANAjetzt added a commit to KANAjetzt/godot-mod-loader that referenced this pull request Mar 24, 2023
If the `load_before` mod is only specified in `load_before`, then it works. However, it would be nice if the `load_before` mod could also be added to `dependencies` or `optional_dependencies`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant