Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: ♻️ ModManifest - Added type checks #163

Merged
merged 1 commit into from
Mar 2, 2023
Merged

refactor: ♻️ ModManifest - Added type checks #163

merged 1 commit into from
Mar 2, 2023

Conversation

KANAjetzt
Copy link
Member

Added type check to _get_string_from_dict() and _get_array_from_dict()

@KANAjetzt KANAjetzt added enhancement New feature or request validation Feature to make things safe and predictable labels Mar 2, 2023
@KANAjetzt KANAjetzt requested review from Qubus0 and a team March 2, 2023 16:55
@KANAjetzt KANAjetzt mentioned this pull request Mar 2, 2023
Merged
Qubus0
Qubus0 approved these changes Mar 2, 2023
View reviewed changes
Copy link
Collaborator

@Qubus0 Qubus0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how could I miss that lol. We could also return str(dict[key]), but I'm not sure if that would be considered the "expected" behaviour

@KANAjetzt
refactor: ♻️ ModManifest added type checks
5c5c0d8 
Added type check to `_get_string_from_dict()` and `_get_array_from_dict()`
@KANAjetzt KANAjetzt force-pushed the manifest_check_type branch from 453509a to 5c5c0d8 Compare March 2, 2023 20:33
@KANAjetzt KANAjetzt added this pull request to the merge queue Mar 2, 2023
Merged via the queue into GodotModding:development with commit 02d128b Mar 2, 2023
@KANAjetzt KANAjetzt deleted the manifest_check_type branch March 2, 2023 20:36
@KANAjetzt KANAjetzt mentioned this pull request Mar 9, 2023
Closed
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Qubus0 Qubus0 Qubus0 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request validation Feature to make things safe and predictable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KANAjetzt @Qubus0