Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ♻️ split validation functions #191

Conversation

KANAjetzt
Copy link
Member

Using is_mod_id_array_valid() for dependencies optional_dependencies and incompatibilities

closes #190

Using `is_mod_id_array_valid()` for `dependencies` `optional_dependencies` and `incompatibilities`

closes GodotModding#190
@KANAjetzt KANAjetzt added validation Feature to make things safe and predictable refactor / cleanup Improves readability or maintainability labels Mar 28, 2023
@KANAjetzt KANAjetzt added this to the v6.0.0 milestone Mar 28, 2023
@KANAjetzt KANAjetzt requested review from Qubus0 and a team March 28, 2023 10:12
Copy link
Collaborator

@Qubus0 Qubus0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ clean

@KANAjetzt KANAjetzt added this pull request to the merge queue Mar 28, 2023
Merged via the queue into GodotModding:development with commit 4cbdbca Mar 28, 2023
@KANAjetzt KANAjetzt deleted the refactor_split_validate_dependencies_and_incompatibilities_func branch March 30, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor / cleanup Improves readability or maintainability validation Feature to make things safe and predictable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants