Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ✨ Added validation for load_before #194

Merged
merged 2 commits into from
Mar 29, 2023
Merged

feat: ✨ Added validation for load_before #194

merged 2 commits into from
Mar 29, 2023

Conversation

KANAjetzt
Copy link
Member

@KANAjetzt KANAjetzt commented Mar 28, 2023 •
edited
Loading

Checks if the same mod id is in

  • load_before <-> dependencies
  • load_before <-> optional_dependencies

closes #187

@KANAjetzt KANAjetzt added the validation Feature to make things safe and predictable label Mar 28, 2023
@KANAjetzt KANAjetzt added this to the v6.0.0 milestone Mar 28, 2023
@KANAjetzt KANAjetzt requested review from Qubus0 and a team March 28, 2023 15:02
Qubus0
Qubus0 approved these changes Mar 28, 2023
View reviewed changes
Copy link
Collaborator

@Qubus0 Qubus0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getting safer by the minute. nice

addons/mod_loader/classes/mod_manifest.gd Show resolved Hide resolved
Qubus0
Qubus0 approved these changes Mar 29, 2023
View reviewed changes
Copy link
Collaborator

@Qubus0 Qubus0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep that works

@KANAjetzt KANAjetzt force-pushed the feat_validate_load_before branch from 26065ed to 8bdcb21 Compare March 29, 2023 13:23
@KANAjetzt
feat: ✨ Added validation for load_before
e28f8ac 
Checks if the same mod id is in `load_before` <-> `dependencies` and `load_before` <-> `optional_dependencies`
@KANAjetzt KANAjetzt force-pushed the feat_validate_load_before branch from 8bdcb21 to e28f8ac Compare March 29, 2023 13:27
@KANAjetzt KANAjetzt added this pull request to the merge queue Mar 29, 2023
Merged via the queue into GodotModding:development with commit 28ce51b Mar 29, 2023
@KANAjetzt KANAjetzt deleted the feat_validate_load_before branch March 30, 2023 10:15
@KANAjetzt KANAjetzt mentioned this pull request Jun 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otDan otDan otDan left review comments

@Qubus0 Qubus0 Qubus0 approved these changes

Assignees
No one assigned
Labels
validation Feature to make things safe and predictable
Projects
None yet
Milestone
3.x - v6.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@KANAjetzt @Qubus0 @otDan