fix: 🐛 Fix mod id validation

[Qubus0]

really simple check for length 3
@ithinkandicode do we really need all of that type stuff at the beginning of the method? what was the intended use for that and will that be followed up upon?

[KANAjetzt]

What type stuff exactly?
That one?

godot-mod-loader/addons/mod_loader/classes/mod_manifest.gd

Line 354 in bc09c11

var intro_text = "A %s for the mod \"%s\" is invalid: " % [type, original_mod_id] if not type == "" else ""

[Qubus0]

yep that. it seems to only check if it is empty and it is only ever set as empty string.

[KANAjetzt]

It's used in the error message to pass the field name.

godot-mod-loader/addons/mod_loader/classes/mod_manifest.gd

Lines 101 to 104 in bc09c11

	not is_mod_id_array_valid(mod_id, dependencies, "dependency") or
	not is_mod_id_array_valid(mod_id, incompatibilities, "incompatibility") or
	not is_mod_id_array_valid(mod_id, optional_dependencies, "optional_dependency") or
	not is_mod_id_array_valid(mod_id, load_before, "load_before")

[Qubus0]

oh I missed the usage in that. disregard that comment then

[KANAjetzt]

Approved ✅
Do we consider this a breaking change? 😬

[Qubus0]

yeah probably breaking. though name and namespace are validated with 3 characters already