Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ Option to skip deprecated fatal error #207

Conversation

ithinkandicode
Copy link
Collaborator

@ithinkandicode ithinkandicode commented Apr 1, 2023

Slightly refactors ModLoaderDeprecated to support a new ML Option, which downgrades the fatal errors from deprecated methods to just warnings.

This is mainly to help existing mods transition to ML v6, considering major breaking changes like #208.

Note: I know we agreed to concat strings with + instead of str (in #166), and this file still uses str, but that can be handled in a different PR as this one is only focused on this feature.

Copy link
Member

@KANAjetzt KANAjetzt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice ty 👍

@KANAjetzt KANAjetzt added this to the v6.0.0 milestone Apr 2, 2023
Copy link
Collaborator

@Qubus0 Qubus0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could go even further and just use that setting to downgrade all fatal logs to error logs? Could make it easier to fix many issues at the same time.

addons/mod_loader/api/deprecated.gd Show resolved Hide resolved
@ithinkandicode ithinkandicode added this pull request to the merge queue Apr 4, 2023
Merged via the queue into GodotModding:development with commit f8185e0 Apr 4, 2023
@ithinkandicode ithinkandicode changed the title feat: Option to skip deprecated fatal error feat: ✨ Option to skip deprecated fatal error Apr 27, 2023
@ithinkandicode ithinkandicode deleted the skip-deprecated-fatal-error branch May 7, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants