Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cli argument for mod folder path #28

Merged
merged 4 commits into from
Jan 15, 2023
Merged

Add cli argument for mod folder path #28

merged 4 commits into from
Jan 15, 2023

Conversation

otDan
Copy link
Member

@otDan otDan commented Jan 15, 2023

Adds a cli argument that allows for thunderstore to specify different mod folders path in different profiles.

@otDan otDan requested a review from ithinkandicode January 15, 2023 07:50
@ithinkandicode
Copy link
Collaborator

ithinkandicode commented Jan 15, 2023

Note: You can test CLI args in the editor via Project Settings > Display> Editor > Main Run Args.

image

Here's 2 test mods for Brotato you can try this with. They've been updated to use the manifest changes we recently merged. They append the version string on the title screen, so it's easy to confirm they're working. I've tested them myself after making the requested changes, and can confirm that they work correctly! 🤗

Darkly77-VersionString1-ML3.1.zip
Darkly77-VersionString2-ML3.1.zip

Copy link
Collaborator

@ithinkandicode ithinkandicode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Submitted review

loader/mod_loader.gd Outdated Show resolved Hide resolved
loader/mod_loader.gd Outdated Show resolved Hide resolved
loader/mod_loader.gd Outdated Show resolved Hide resolved
loader/mod_loader.gd Show resolved Hide resolved
@otDan otDan merged commit 0edb3b9 into main Jan 15, 2023
@otDan otDan deleted the thunderstore branch January 15, 2023 10:47
This was referenced Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants