Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not using camelcase for save_scene #45

Merged
merged 1 commit into from
Jan 16, 2023
Merged

Fix not using camelcase for save_scene #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions loader/mod_loader.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ var os_mods_path_override = ""
# Example property: "mod_id": ["dep_mod_id_0", "dep_mod_id_2"]
var mod_missing_dependencies = {}

# Things to keep to ensure they are not garbage collected (used by `saveScene`)
# Things to keep to ensure they are not garbage collected (used by `save_scene`)
var _saved_objects = []


Expand Down Expand Up @@ -688,10 +688,10 @@ func append_node_in_scene(modified_scene, node_name:String = "", node_parent = n
new_node.set_owner(modified_scene)


func save_scene(modified_scene, scenePath:String):
func save_scene(modified_scene, scene_path:String):
var packed_scene = PackedScene.new()
packed_scene.pack(modified_scene)
dev_log(str("packing scene -> ", packed_scene), LOG_NAME)
packed_scene.take_over_path(scenePath)
dev_log(str("saveScene - taking over path - new path -> ", packed_scene.resource_path), LOG_NAME)
packed_scene.take_over_path(scene_path)
dev_log(str("save_scene - taking over path - new path -> ", packed_scene.resource_path), LOG_NAME)
_saved_objects.append(packed_scene)