Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix log-ignore flag #70

Merged
merged 1 commit into from
Jan 20, 2023
Merged

fix log-ignore flag #70

merged 1 commit into from
Jan 20, 2023

Conversation

Qubus0
Copy link
Collaborator

@Qubus0 Qubus0 commented Jan 20, 2023

should cover no flag and any flag. spaces still do not work due to godot splitting them.
new format: --log-ignore=ModLoader,ModLoader:ModData,TestMod (no spaces, no quotation marks)

@Qubus0 Qubus0 requested a review from a team January 20, 2023 23:47
KANAjetzt
KANAjetzt approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@KANAjetzt KANAjetzt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔨

@Qubus0 Qubus0 merged commit 8add151 into GodotModding:main Jan 20, 2023
@Qubus0 Qubus0 deleted the fix_log_ignoring branch January 20, 2023 23:52
@KANAjetzt KANAjetzt mentioned this pull request Jan 22, 2023
Merged
@ithinkandicode ithinkandicode mentioned this pull request Feb 22, 2023
Merged
@KANAjetzt KANAjetzt mentioned this pull request Feb 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KANAjetzt KANAjetzt KANAjetzt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Qubus0 @KANAjetzt