refactor: ♻️ moved editor base theme to store.gd #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qubus0
reviewed
Feb 24, 2023
| @@ -219,22 +219,22 @@ margin_bottom = -4.0 | |||
| [node name="ScrollContainer" type="ScrollContainer" parent="TabContainer/Mod Manifest"] | |||
| margin_left = 7.0 | |||
| margin_top = 7.0 | |||
| margin_right = 1925.0 | |||
There was a problem hiding this comment.
I think we are ping-ponging these margins back and forth because of different screen resolutions..
But I think that only updates if something else in the scene was updated - in this case, which one of the tabs is visible
There was a problem hiding this comment.
yep that's a bit annoying, if we didn't change something in the scene, we can just discard the changes before committing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved editor base theme to store.gd so it's easier to access.
I left the json_editor.gd as is. Because it uses a set function on the
base_themevar.