refactor: ♻️ Add / Remove ModToolStore as a singleton/autoload #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding the ModToolStore as a singleton on `_enter_tree()` in *plugin.gd* allows easy access from any where in the plugin. Refactored every store reference to use the new singleton. The singleton get's removed in `_exit_tree()` in *plugin.gd*.
Qubus0
approved these changes
Feb 28, 2023
Before `save_store()` was called in `_exit_tree()` in *dock.gd*. Resulting in an error, because the autoload is removed before `_exit_tree()` was executed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the ModToolStore as a singleton on
_enter_tree()in plugin.gd allows easy access from any where in the plugin. Refactored every store reference to use the new singleton. The singleton get's removed in_exit_tree()in plugin.gd.