Redirect to correct local port after OAuth2 success #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The redirect_uri param always defaulted to http://localhost:8030 even when using a port other than default on function call get_auth_localhost
WolfgangSenff
approved these changes
Jan 11, 2024
|
I will go ahead and add this same functionality to the 4.x branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The redirect_uri param always defaulted to http://localhost:8060 even when using a port other than default on function call get_auth_localhost.
The relevant issue number, if applicable.
No issue has been opened.
Any new features that have been added
Added a setter to _local_port to re-create the _local_uri var according to the port specified.
Any relevant tests that have been run
No relevant test have been run or written