Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #372 delete_document error #373

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Conversation

xzirox
Copy link
Contributor

@xzirox xzirox commented Dec 20, 2023

Fixed by adding a bool parameter to the _on_delete_document function in firestore_collection.gd

Copy link
Collaborator

@WolfgangSenff WolfgangSenff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this not require updating wherever it's called as well?

@xzirox
Copy link
Contributor Author

xzirox commented Jan 11, 2024

Does this not require updating wherever it's called as well?

No, because the delete_document signal in firestore_task.gd already emits the boolean as a parameter to the signal.

@WolfgangSenff
Copy link
Collaborator

Ahh, interesting, okay. Is it emitted that way everywhere? Or is that the only place?

@xzirox
Copy link
Contributor Author

xzirox commented Jan 11, 2024

Ahh, interesting, okay. Is it emitted that way everywhere? Or is that the only place?

That's the only place that emits the original signal that firestore_collection.gd hooks into.

@WolfgangSenff
Copy link
Collaborator

WolfgangSenff commented Jan 11, 2024

Alright, sounds good then! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants