Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make vignette work both in Godot 4.2 and 4.3 #678

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Make vignette work both in Godot 4.2 and 4.3 #678

merged 1 commit into from
Sep 16, 2024

Conversation

BastiaanOlij
Copy link
Member

@BastiaanOlij BastiaanOlij commented Sep 16, 2024 •
edited
Loading

This fixes the code for our vignette logic so it works in both Godot 4.2 and 4.3

Fixes #668

@BastiaanOlij BastiaanOlij added the bug Something isn't working label Sep 16, 2024
@BastiaanOlij BastiaanOlij added this to the 4.4.0 milestone Sep 16, 2024
@BastiaanOlij BastiaanOlij self-assigned this Sep 16, 2024
Malcolmnixon
Malcolmnixon approved these changes Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@Malcolmnixon Malcolmnixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me - tested on both Godot 4.2.2-stable, and 4.3-stable - definitely handles the two styles of Z representation.

@BastiaanOlij BastiaanOlij merged commit f68e60a into GodotVR:master Sep 16, 2024
2 checks passed
@BastiaanOlij BastiaanOlij deleted the fix_vignette_43 branch September 16, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Malcolmnixon Malcolmnixon Malcolmnixon approved these changes

Assignees

@BastiaanOlij BastiaanOlij

Labels
bug Something isn't working
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.

Godot 4.3: Vignette unusable
2 participants
@BastiaanOlij @Malcolmnixon