Implement hole punch functionality for OpenXRFbPassthroughGeometry node
#139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4gr3d
reviewed
May 7, 2024
devloglogan
force-pushed
the
fb-passthrough-hole-punch
branch
from
33da131 to
7e0b210
Compare
m4gr3d
requested changes
May 7, 2024
devloglogan
force-pushed
the
fb-passthrough-hole-punch
branch
from
7e0b210 to
da501fa
Compare
devloglogan
force-pushed
the
fb-passthrough-hole-punch
branch
from
da501fa to
025886c
Compare
m4gr3d
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a similar fashion to godotengine/godot#91485, implements "hole punching" for fb passthrough geometry. This mode makes it so objects behind the passthrough geometry will not be seen, like the clip in this comment. The passthrough geometry in this repo's demo now has this enabled.
I believe this mode would be the more common use case for passthrough geometry, so I've set
enable_hole_punchtotrueby default.