Add support for HTC passthrough #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BastiaanOlij
force-pushed
the
add_htc_passthrough
branch
3 times, most recently
from
e003189 to
e60dd4e
Compare
This was referenced May 16, 2024
m4gr3d
reviewed
May 16, 2024
common/src/main/cpp/extensions/openxr_fb_passthrough_extension_wrapper.cpp
Outdated
Show resolved
Hide resolved
BastiaanOlij
force-pushed
the
add_htc_passthrough
branch
from
e60dd4e to
eae51ac
Compare
m4gr3d
reviewed
May 16, 2024
common/src/main/cpp/include/extensions/openxr_htc_passthrough_extension_wrapper.h
Outdated
Show resolved
Hide resolved
m4gr3d
reviewed
May 16, 2024
common/src/main/cpp/extensions/openxr_htc_passthrough_extension_wrapper.cpp
Outdated
Show resolved
Hide resolved
m4gr3d
reviewed
May 16, 2024
common/src/main/cpp/extensions/openxr_htc_passthrough_extension_wrapper.cpp
Outdated
Show resolved
Hide resolved
m4gr3d
reviewed
May 16, 2024
common/src/main/cpp/extensions/openxr_htc_passthrough_extension_wrapper.cpp
Outdated
Show resolved
Hide resolved
m4gr3d
reviewed
May 16, 2024
common/src/main/cpp/extensions/openxr_htc_passthrough_extension_wrapper.cpp
Outdated
Show resolved
Hide resolved
BastiaanOlij
force-pushed
the
add_htc_passthrough
branch
from
eae51ac to
bb0b3c5
Compare
dsnopek
approved these changes
May 21, 2024
|
Looks like this needs a rebase on conflicts in |
Co-authored-by: seichter
BastiaanOlij
force-pushed
the
add_htc_passthrough
branch
from
bb0b3c5 to
044deef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for HTCs version of passthrough in a way that is transparent to the user.
Here we also react to our blend mode.
I did have to add some extra checks to the Meta implementation because while the HTC implementation became active, Metas implementation wasn't checking whether it was actually active and just started error spamming as a result :P
Note that there is an interesting difference here as well, while Meta explicitly requires us to start and stop passthrough, HTC doesn't. We do need to create a passthrough handle once the session is setup, but from then on passthrough is purely switched on whether the passthrough composition layer is added.
I am making the assumption here, and I think that's a fairly safe assumption, that no device is going to support both Metas and HTCs passthrough extensions. If this does become an issue we may need to do something like
set_emulate_environment_blend_mode_alpha_blendreturning an error when another extension has already claimed it.Tested this on my HTC Elite XR and seems to work fine.
Note, thanks to @seichter (PR godotengine/godot#86407) for doing much of the ground work. Made it really easy to implement this in the vendor plugin.