Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fb composition layer sample project #161

Merged
merged 1 commit into from
May 30, 2024

Conversation

devloglogan
Copy link
Collaborator

Using the same structure as #155, adds a sample project to showcase composition layers along with the functionalities of the related OpenXR extensions. Setting this as a draft for now as the passthrough sample should probably be merged first, in order to more easily ensure this PR follows the structural decisions we're making in the discussion of that PR.

@devloglogan devloglogan added documentation Improvements or additions to documentation enhancement New feature or request labels May 29, 2024
@devloglogan devloglogan added this to the 3.0.0 milestone May 29, 2024
@devloglogan devloglogan force-pushed the composition-layer-sample branch from e6413cb to 5c1372b Compare May 29, 2024 20:51
@devloglogan devloglogan force-pushed the composition-layer-sample branch from 5c1372b to 5dc4e40 Compare May 30, 2024 13:14
@devloglogan devloglogan force-pushed the composition-layer-sample branch from 5dc4e40 to 2fca181 Compare May 30, 2024 13:16
@devloglogan devloglogan marked this pull request as ready for review May 30, 2024 13:17
@devloglogan
Copy link
Collaborator Author

Passthrough sample has been merged so I've opened this PR!

Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tested this and it works great! The code looks good to me as well :-)

Great work!

@m4gr3d m4gr3d merged commit aea1445 into GodotVR:master May 30, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants