Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Godot 4.3-stable #198

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Conversation

devloglogan
Copy link
Collaborator

Update config.grade and godot-cpp to Godot 4.3-stable!

@devloglogan devloglogan added the enhancement New feature or request label Aug 15, 2024
@devloglogan devloglogan added this to the 3.0.0 milestone Aug 15, 2024
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

The tests appear to be failing due to some issue with Meta's NPM server? That's where we download the XR Simulator from and it's just stalling forever, even when I try the link locally:

https://npm.developer.oculus.com/com.meta.xr.simulator/-/com.meta.xr.simulator-65.0.0.tgz

Hopefully they'll fix it soon, but if not, we may need to release without that bit of the tests passing.

@devloglogan
Copy link
Collaborator Author

@m4gr3d @dsnopek Also just updated GODOT_VERSION in build-addon-on-push.yml!

@BastiaanOlij
Copy link
Member

I'm assuming we can ignore the XR simulator check for now?

@BastiaanOlij BastiaanOlij merged commit 8f9488b into GodotVR:master Aug 16, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants