Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add two modes of pico hand tracking to selectable export features #216

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

ckschim
Copy link
Contributor

@ckschim ckschim commented Oct 8, 2024

This should resolve part of #162.

With this, hand tracking for PICO can be explicitly enabled using <meta-data android:name="handtracking" android:value="1"/>
I also added the high frequency mode with <meta-data android:name="Hand_Tracking_HighFrequency" android:value="1"/>

Both options I found in the official PICO SDK for Unity, oddly enough no other documentation anywhere: https://github.com/Pico-Developer/PICO-Unity-Integration-SDK/blob/f07f05f433a9671344c722a13ccc6f259e7e390d/Editor/PXR_BuildProcessor.cs#L229

image

@m4gr3d m4gr3d added this to the 3.1.0 milestone Oct 21, 2024
@m4gr3d m4gr3d added bug Something isn't working enhancement New feature or request labels Oct 21, 2024
@ckschim ckschim force-pushed the pico-hand-tracking branch from 86d9f1b to 39fb0f0 Compare October 22, 2024 05:07
@ckschim ckschim requested a review from m4gr3d October 22, 2024 05:10
Copy link
Collaborator

@m4gr3d m4gr3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@m4gr3d m4gr3d merged commit dbc2180 into GodotVR:master Oct 24, 2024
10 checks passed
@m4gr3d
Copy link
Collaborator

m4gr3d commented Oct 24, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants