-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add meta scene capture api support #53
Add meta scene capture api support #53
Conversation
44829ce
to
3648605
Compare
26a5a29
to
a67ec6e
Compare
@m4gr3d We will check it out, but this weekend is a long weekend in Hungary, we will be back at work on Tuesday. |
51b69f2
to
7c4abae
Compare
I ran into a problem compiling this:
|
oh my bad, forgot to initialise submodules, not used to those not being there yet :) okay, spoke to soon, having issues compiling
Not sure whats going on here as I have no problems compiling Godot for Android, is |
@BastiaanOlij This happens when the We've moved away from this variable in Godot core, I'll send a PR to |
Ok, got it all to compile and works, will be playing with it some more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should just merge this, if anything comes up that needs to be perfected that will come out of people playing around with it.
Sounds good to me! @kisg Any additional feedback? |
Just would like to add a copyright notice for the source files that we contributed will send a PR on top of this one in a few minutes. |
Just noticed that we need to improve the |
7c4abae
to
8b356af
Compare
d64af98
to
e67afda
Compare
Install Android NDK r23c
a60c0fd
to
b57b16b
Compare
Follow-up to the discussion in #40 (comment) about migrating Migeran's implementation of the Meta Scene capture API to the Godot OpenXR Loaders (subject to rename) plugin.
This PR also updates the project to include a
godot-cpp
andopenxr
dependencies for use when implementing the OpenXR gdextension.