Use Engine::get_singleton()->register_singleton(...) to register singletons for the OpenXR extension wrappers
#72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4gr3d
changed the title
Engine::get_singleton()->register_singleton(...) to register si…Engine::get_singleton()->register_singleton(...) to register singletons for the OpenXR extension wrappers
…ngletons for the OpenXR extension wrappers.
m4gr3d
force-pushed
the
fix_extension_singleton_registration
branch
from
eb6d98e to
54e3fea
Compare
dsnopek
reviewed
Jan 12, 2024
| @@ -10,7 +10,7 @@ func _ready(): | |||
| var vp: Viewport = get_viewport() | |||
| vp.use_xr = true | |||
|
|
|||
| scene_capture = OpenXRFbSceneCaptureExtensionWrapper.get_singleton() | |||
| scene_capture = Engine.get_singleton("OpenXRFbSceneCaptureExtensionWrapper") | |||
There was a problem hiding this comment.
You shouldn't need to do the Engine.get_singleton() bit, in GDScript all singletons should be available like globals, ie OpenXRFbSceneCaptureExtensionWrapper.request_scene_capture() should work to call that method. Although, I would also have expected Engine.get_singleton() to work too...
|
Superseded by #73 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.